Question : Problems With The GoTo Code

I have looked aat this code till I am bugeyed and for some reason it simply does not work. With out going into a lot of detail can you look it over and see if anything stands out. This code is suppose to gets its data from different locations on different forms based on the value of a combo box. Right now the code is called from a button for testing purposes.

Code Snippet:

1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:
39:
40:
41:
42:
43:
44:
45:
46:
47:
48:
49:
50:
51:
52:
53:
54:
55:
56:
57:
58:
59:
60:
61:
62:
63:
64:
65:
66:
67:
68:
69:
70:
71:
72:
73:
74:
75:
76:
77:
78:
79:
80:
81:
82:
83:
84:
85:
86:
87:
88:
89:
90:
91:
92:
93:
94:
95:
96:
97:
98:
99:
100:
101:
102:
103:
104:
105:
106:
107:
108:
109:
110:
111:
112:
113:
114:
115:
116:
117:
118:
119:
120:
121:
122:
123:
124:
125:
126:
127:
128:
129:
130:
131:
132:
133:



Private Sub Command120_Click()
If Me.DriverSource.Value = "VICTIM" Then
GoTo Brittany
Else
If Me.DriverSource.Value = "SUSPECT 1" Then
GoTo Morgan
Else
If Me.DriverSource.Value = "SUSPECT 2" Then
GoTo Carson
Else
If Me.DriverSource.Value = "WITNESS 1" Then
GoTo Blaine
Else
If Me.DriverSource.Value = "WITNESS 2" Then
GoTo Mickey
Else
If Me.DriverSource.Value = "WITNESS 3" Then
GoTo Carbo
 
 
Brittany:
Me.DriverName.Value = Forms!AlioBack!FirstLastVictim
Me.DriverAddress = Forms!AlioBack!VictimAddress
Me.DriverCity = Forms!AlioBack!VictimCity
Me.DriverSt = Forms!AlioBack!VictimState
Me.DriverZip = Forms!AlioBack!VictimZip
Me.VehicleMake = Forms!AlioFront!VehicleMake
Me.VehicleModle = Forms!AlioFront!VehicleModel
Me.Text104 = Forms!AlioFront!VehicleStyle
Me.VehicleYear = Forms!AlioFront!VehicleYear
Me.VehicleColorTop = Forms!AlioFront!VehicleColorTop
Me.VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
Me.VehicleTag = Forms!AlioFront!VehicleLicense
Me.VehicleTagState = Forms!AlioFront!LicenseState
Me.VehicleVIN = Forms!AlioFront!VehicleVIN
 
Morgan:
Me.DriverName.Value = Forms!AlioBack!FirstLastOffender
Me.DriverAddress = Forms!AlioBack!OffenderAddress
Me.DriverCity = Forms!AlioBack!OffenderCity
Me.DriverSt = Forms!AlioBack!OffenderState
Me.DriverZip = Forms!AlioBack!OffenderZip
Me.DriverPhone = Forms!AlioBack!OffenderPhone
Me.VehicleMake = Forms!AlioFront!VehicleMake
Me.VehicleModle = Forms!AlioFront!VehicleModel
Me.Text104 = Forms!AlioFront!VehicleStyle
Me.VehicleYear = Forms!AlioFront!VehicleYear
Me.VehicleColorTop = Forms!AlioFront!VehicleColorTop
Me.VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
Me.VehicleTag = Forms!AlioFront!VehicleLicense
Me.VehicleTagState = Forms!AlioFront!LicenseState
Me.VehicleVIN = Forms!AlioFront!VehicleVIN
 
 
Carson:
Me.DriverName.Value = Forms!AlioBack!Offender2FirstLast
Me.DriverAddress = Forms!AlioBack!Offender2Address
Me.DriverCity = Forms!AlioBack!Offender2City
Me.DriverSt = Forms!AlioBack!Offender2State
Me.DriverZip = Forms!AlioBack!Offender2Zip
Me.DriverPhone = Forms!AlioBack!OffenderPhone
Me.VehicleMake = Forms!AlioFront!VehicleMake
Me.VehicleModle = Forms!AlioFront!VehicleModel
Me.Text104 = Forms!AlioFront!VehicleStyle
Me.VehicleYear = Forms!AlioFront!VehicleYear
Me.VehicleColorTop = Forms!AlioFront!VehicleColorTop
Me.VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
Me.VehicleTag = Forms!AlioFront!VehicleLicense
Me.VehicleTagState = Forms!AlioFront!LicenseState
Me.VehicleVIN = Forms!AlioFront!VehicleVIN
 
 
 
 
Blaine:
Me.DriverName.Value = Forms!AlioBack!Witness1FirstLast
Me.DriverAddress = Forms!AlioBack!Witness1Address
Me.DriverCity = Forms!AlioBack!Witness1City
Me.DriverSt = Forms!AlioBack!Witness1State
Me.DriverZip = Forms!AlioBack!Witness1Zip
Me.DriverPhone = Forms!AlioBack!Witness1PhoneHome
Me.VehicleMake = Forms!AlioFront!VehicleMake
Me.VehicleModle = Forms!AlioFront!VehicleModel
Me.Text104 = Forms!AlioFront!VehicleStyle
Me.VehicleYear = Forms!AlioFront!VehicleYear
Me.VehicleColorTop = Forms!AlioFront!VehicleColorTop
Me.VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
Me.VehicleTag = Forms!AlioFront!VehicleLicense
Me.VehicleTagState = Forms!AlioFront!LicenseState
Me.VehicleVIN = Forms!AlioFront!VehicleVIN
 
Mickey:
Me.DriverName.Value = Forms!AlioBack!Witness2FirstLast
Me.DriverAddress = Forms!AlioBack!Witness2Address
Me.DriverCity = Forms!AlioBack!Witness2City
Me.DriverSt = Forms!AlioBack!Witness2State
Me.DriverZip = Forms!AlioBack!Witness2Zip
Me.DriverPhone = Forms!AlioBack!Witness2PhoneHome
Me.VehicleMake = Forms!AlioFront!VehicleMake
Me.VehicleModle = Forms!AlioFront!VehicleModel
Me.Text104 = Forms!AlioFront!VehicleStyle
Me.VehicleYear = Forms!AlioFront!VehicleYear
Me.VehicleColorTop = Forms!AlioFront!VehicleColorTop
Me.VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
Me.VehicleTag = Forms!AlioFront!VehicleLicense
Me.VehicleTagState = Forms!AlioFront!LicenseState
Me.VehicleVIN = Forms!AlioFront!VehicleVIN
 
Carbo:
Me.DriverName.Value = Forms!AlioBack!Witness3FirstLast
Me.DriverAddress = Forms!AlioBack!Witness3Address
Me.DriverCity = Forms!AlioBack!Witness3City
Me.DriverSt = Forms!AlioBack!Witness3State
Me.DriverZip = Forms!AlioBack!Witness3Zip
Me.DriverPhone = Forms!AlioBack!Witness3PhoneHome
Me.VehicleMake = Forms!AlioFront!VehicleMake
Me.VehicleModle = Forms!AlioFront!VehicleModel
Me.Text104 = Forms!AlioFront!VehicleStyle
Me.VehicleYear = Forms!AlioFront!VehicleYear
Me.VehicleColorTop = Forms!AlioFront!VehicleColorTop
Me.VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
Me.VehicleTag = Forms!AlioFront!VehicleLicense
Me.VehicleTagState = Forms!AlioFront!LicenseState
Me.VehicleVIN = Forms!AlioFront!VehicleVIN
 
End If
End If
End If
End If
End If
End If
 
End Sub

Open in New Window

Select All

Answer : Problems With The GoTo Code

When you go to each section, there is nothing to prevent the code from continuing to the next section; that is, if you GoTo Brittney:, the last line is this:

Me.VehicleVIN = Forms!AlioFront!VehicleVIN

The next line, though, is this:

Morgan:

so that it continues with Morgan when done with Brittany.

Unless that is what you want, enter an Exit Sub before each label:

At the end of Brittany:

Exit Sub
Morgan:

However, this would all be better using a SELECT CASE, like this:

Private Sub Command120_Click()
Select Case DriverSource
      Case "VICTIM"
            DriverNaValue = Forms!AlioBack!FirstLastVictim
            DriverAddress = Forms!AlioBack!VictimAddress
            DriverCity = Forms!AlioBack!VictimCity
            DriverSt = Forms!AlioBack!VictimState
            DriverZip = Forms!AlioBack!VictimZip
            VehicleMake = Forms!AlioFront!VehicleMake
            VehicleModle = Forms!AlioFront!VehicleModel
            Text104 = Forms!AlioFront!VehicleStyle
            VehicleYear = Forms!AlioFront!VehicleYear
            VehicleColorTop = Forms!AlioFront!VehicleColorTop
            VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
            VehicleTag = Forms!AlioFront!VehicleLicense
            VehicleTagState = Forms!AlioFront!LicenseState
            VehicleVIN = Forms!AlioFront!VehicleVIN
      Case "SUSPECT 1"
            DriverNaValue = Forms!AlioBack!FirstLastOffender
            DriverAddress = Forms!AlioBack!OffenderAddress
            DriverCity = Forms!AlioBack!OffenderCity
            DriverSt = Forms!AlioBack!OffenderState
            DriverZip = Forms!AlioBack!OffenderZip
            DriverPhone = Forms!AlioBack!OffenderPhone
            VehicleMake = Forms!AlioFront!VehicleMake
            VehicleModle = Forms!AlioFront!VehicleModel
            Text104 = Forms!AlioFront!VehicleStyle
            VehicleYear = Forms!AlioFront!VehicleYear
            VehicleColorTop = Forms!AlioFront!VehicleColorTop
            VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
            VehicleTag = Forms!AlioFront!VehicleLicense
            VehicleTagState = Forms!AlioFront!LicenseState
            VehicleVIN = Forms!AlioFront!VehicleVIN
      Case "SUSPECT 2"
            DriverNaValue = Forms!AlioBack!Offender2FirstLast
            DriverAddress = Forms!AlioBack!Offender2Address
            DriverCity = Forms!AlioBack!Offender2City
            DriverSt = Forms!AlioBack!Offender2State
            DriverZip = Forms!AlioBack!Offender2Zip
            DriverPhone = Forms!AlioBack!OffenderPhone
            VehicleMake = Forms!AlioFront!VehicleMake
            VehicleModle = Forms!AlioFront!VehicleModel
            Text104 = Forms!AlioFront!VehicleStyle
            VehicleYear = Forms!AlioFront!VehicleYear
            VehicleColorTop = Forms!AlioFront!VehicleColorTop
            VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
            VehicleTag = Forms!AlioFront!VehicleLicense
            VehicleTagState = Forms!AlioFront!LicenseState
            VehicleVIN = Forms!AlioFront!VehicleVIN
      Case "WITNESS 1"
            DriverNaValue = Forms!AlioBack!Witness2FirstLast
            DriverAddress = Forms!AlioBack!Witness2Address
            DriverCity = Forms!AlioBack!Witness2City
            DriverSt = Forms!AlioBack!Witness2State
            DriverZip = Forms!AlioBack!Witness2Zip
            DriverPhone = Forms!AlioBack!Witness2PhoneHome
            VehicleMake = Forms!AlioFront!VehicleMake
            VehicleModle = Forms!AlioFront!VehicleModel
            Text104 = Forms!AlioFront!VehicleStyle
            VehicleYear = Forms!AlioFront!VehicleYear
            VehicleColorTop = Forms!AlioFront!VehicleColorTop
            VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
            VehicleTag = Forms!AlioFront!VehicleLicense
            VehicleTagState = Forms!AlioFront!LicenseState
            VehicleVIN = Forms!AlioFront!VehicleVIN

      Case "WITNESS 2"
            DriverNaValue = Forms!AlioBack!Witness2FirstLast
            DriverAddress = Forms!AlioBack!Witness2Address
            DriverCity = Forms!AlioBack!Witness2City
            DriverSt = Forms!AlioBack!Witness2State
            DriverZip = Forms!AlioBack!Witness2Zip
            DriverPhone = Forms!AlioBack!Witness2PhoneHome
            VehicleMake = Forms!AlioFront!VehicleMake
            VehicleModle = Forms!AlioFront!VehicleModel
            Text104 = Forms!AlioFront!VehicleStyle
            VehicleYear = Forms!AlioFront!VehicleYear
            VehicleColorTop = Forms!AlioFront!VehicleColorTop
            VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
            VehicleTag = Forms!AlioFront!VehicleLicense
            VehicleTagState = Forms!AlioFront!LicenseState
            VehicleVIN = Forms!AlioFront!VehicleVIN
      Case "WITNESS 3"
            DriverNaValue = Forms!AlioBack!Witness3FirstLast
            DriverAddress = Forms!AlioBack!Witness3Address
            DriverCity = Forms!AlioBack!Witness3City
            DriverSt = Forms!AlioBack!Witness3State
            DriverZip = Forms!AlioBack!Witness3Zip
            DriverPhone = Forms!AlioBack!Witness3PhoneHome
            VehicleMake = Forms!AlioFront!VehicleMake
            VehicleModle = Forms!AlioFront!VehicleModel
            Text104 = Forms!AlioFront!VehicleStyle
            VehicleYear = Forms!AlioFront!VehicleYear
            VehicleColorTop = Forms!AlioFront!VehicleColorTop
            VehicleColorBottom = Forms!AlioFront!VehicleColorBottom
            VehicleTag = Forms!AlioFront!VehicleLicense
            VehicleTagState = Forms!AlioFront!LicenseState
            VehicleVIN = Forms!AlioFront!VehicleVIN
      End Select
End Sub

so I would probably use a SELECT CASE instead of all the